Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add help command #42

Merged
merged 2 commits into from Nov 6, 2020
Merged

Add help command #42

merged 2 commits into from Nov 6, 2020

Conversation

pickfire
Copy link
Collaborator

@pickfire pickfire commented Nov 1, 2020

Close #41

cc @andy128k

Screenshot_20201102_012616

For the next thing I would probably add color to clap help message.

pickfire
pickfire commented Nov 1, 2020
View reviewed changes
src/error/mod.rs Outdated Show resolved Hide resolved
@andy128k
Copy link

andy128k commented Nov 2, 2020

Nice!

Few comments:

  1. Order of operators is strange.
  2. README also mentions **
  3. README says nothing about !

@nerdypepper
Copy link
Owner

Looking good @pickfire.

@andy128k ** doesn't show up because it is an alias for ^, implemented only on the parsing end, there is no entry for the same in the OPERATORS hashmap. The factorial operator is missing from the readme, good catch!

@pickfire
Fix help on smaller terminal
8ff4083 
COLUMNS not working, using term_size crate for a more portable
solution.
@nerdypepper nerdypepper merged commit cf7005d into nerdypepper:master Nov 6, 2020
@nerdypepper
Copy link
Owner

Thanks a lot for working on this @pickfire!

@pickfire pickfire deleted the help branch November 6, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdypepper nerdypepper nerdypepper left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "help" command
3 participants
@pickfire @andy128k @nerdypepper