Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large value for year causes browser to hang #67

Closed
ghost opened this issue Jan 6, 2014 · 15 comments
Closed

Large value for year causes browser to hang #67

ghost opened this issue Jan 6, 2014 · 15 comments

Comments

@ghost
Copy link

ghost commented Jan 6, 2014

I'm experiencing the same problem described here: uxsolutions/bootstrap-datepicker#512

However, I'm not filing it upstream because I can't reproduce it with eternicode's version.

Here's the relevant invocation, if it helps:

    $('.date').datepicker
      autoclose: true
      forceParse: false
      format: 'mm/dd/yyyy'

Out of curiosity, I noticed in the latest diff that the version was adjusted to "1.1.1.11". I'm guessing this is reflecting eternicode's versioning? bootstrap-datepicker has an official 1.2 release... are the assets here reflecting the tagged releases, or the changes made in master? If it's the latter, eternicode's comment here makes me wonder if master contains everything a tagged release does.

@Nerian
Copy link
Owner

Nerian commented Jan 6, 2014

Hi,

That's interesting. So I should be using the release branch instead of master. Alrighty, I just did that and released a new version '1.3.0.1.rc5'. This should have the same code as the release branch.

@ghost
Copy link
Author

ghost commented Jan 7, 2014

@Nerian, thanks for the lightning-fast update. Unfortunately, I'm still experiencing problems... do you know of any other possible discrepancies?

@Nerian
Copy link
Owner

Nerian commented Jan 7, 2014

Which branch in the original repo did you use that gave no error?

@ghost
Copy link
Author

ghost commented Jan 7, 2014

The release branch. For a sanity check, here's a jsfiddle with the assets from the branch pasted right in: http://jsfiddle.net/jFSHd/

@Nerian
Copy link
Owner

Nerian commented Jan 7, 2014

The JS code is the same in both places. I am not sure why there are different results.:confused:

@ghost
Copy link
Author

ghost commented Jan 7, 2014

Could be an issue on my end? Any chance of you reproducing it with your latest release?

@Nerian
Copy link
Owner

Nerian commented Jan 7, 2014

I did reproduced it on the test app https://github.com/Nerian/bootstrap-datepicker-rails/tree/master/testapp

So it's not an error on your side

@Nerian
Copy link
Owner

Nerian commented Jan 7, 2014

I wonder if the reason why we don't get this error on the fiddle is because fiddle has some kind of mechanism for protecting the parent view from the experimental code

@Nerian
Copy link
Owner

Nerian commented Jan 7, 2014

Nope, fiddle does freeze with

while(true){
    console.log('whaaat')
}

@ghost
Copy link
Author

ghost commented Jan 9, 2014

I'm at a total loss. I removed your gem from my Gemfile and tried loading the assets manually - still no dice.

I edited the fiddle to use the same version of jQuery (1.10.2) as my app - couldn't reproduce.

I wonder about potential conflicts with other Gems, but your test app contains next to nothing.

@Nerian
Copy link
Owner

Nerian commented Jan 16, 2014

I just released a new version. Maybe this fixed you issue?

@ghost
Copy link
Author

ghost commented Jan 16, 2014

No, still no luck... 😢

@Nerian
Copy link
Owner

Nerian commented Dec 19, 2014

A new gem was released yesterday. You probably moved on already but ... :)

@Nerian Nerian closed this as completed Dec 19, 2014
@ghost
Copy link
Author

ghost commented Dec 19, 2014

Is this fixed in the new release?

@Nerian
Copy link
Owner

Nerian commented Dec 20, 2014

The new release contains the latest code. Maybe the issue you described was fixed. Not sure.

@Nerian Nerian reopened this Dec 20, 2014
@Nerian Nerian closed this as completed Dec 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant