New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: as per React: unmount callbacks should be called before removing DOM #32
Comments
See https://codesandbox.io/s/j2wym3n6w5 for Nerv behavior. But still, there is bug in Top level API |
My point was that when doing keyed algo you remove DOM first, then call the callbacks. Ok I create full reproduce wait a sec. |
https://codesandbox.io/s/3x29y3040m another where it fails: https://codesandbox.io/s/5xpp5q4lyn |
Thanks for the reproduce. It's a really nice that you can help us on the weekend. ❤️ |
There is serval tests for this issue. |
unmount callbacks should be called before removing DOM.
See https://jsfiddle.net/Luotcj1f/ for React behavior.
at least this line in wrong:
https://github.com/NervJS/nerv/blob/master/packages/nerv/src/vdom/patch.ts#L95-L96
Didn't check any other places.
The text was updated successfully, but these errors were encountered: