feat(Calendar): Calendar 组件添加仅显示有效时间组功能 #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SzHeJason 不好意思 我是因为自己项目 package.json 直接引用了 自己仓库的分支为了使用新添加的这个功能 忘记了这个分支已经提 PR 了 我回滚一下 |
zhgqthomas
force-pushed
the
feature_compoent_calendar_validdates
branch
from
71b77b9
to
da46998
Compare
|
@SzHeJason 已回滚 |
SzHeJason
reviewed
Apr 18, 2019
|
|
||
| if (!_isEmpty(validDates)) { | ||
| let isInclude = false; | ||
| _forEach(validDates, date => { // 判断当前日期是否在有效时间组内 |
There was a problem hiding this comment.
这块逻辑可以优化一下 如果你追求性能 那么 isInclude 为 true 的时候 剩下的还需要判断吗？ 如果你追求代码的简洁性 那用 Array.some 会不会更好呢？
There was a problem hiding this comment.
代码已经改用 Array.some 来提高代码简洁性，因并不是经常使用 JS，所以不知道有 Array.some 这个方法，学习了，感谢~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
通过给 Calendar 传入 validDates 属性，使日历仅显示有效时间组的日期，其余时间全部置灰且无法点击。fix #526