Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pxtransform enable false 样式不进行缩放也能支持跨平台注释代码 #11296

Closed
shinken008 opened this issue Feb 17, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request T-rn Target - 编译到 React Native V-3 Version - 3.x

Comments

@shinken008
Copy link
Collaborator

shinken008 commented Feb 17, 2022

这个特性解决了什么问题?

步骤:

  1. 手动关闭 pxtransform
     pxtransform: {
        enable: false,
        config: {}
      }
  1. 跨平台样式注释也能生效,目前功能是耦合在 pxtransform 里面
/*  #ifndef  %PLATFORM%   */
&:not(:first-child) {
    border-top: 20px solid #f5f5f5;
}
/*  #endif  */

这个 API 长什么样?

解决方案:

  1. pxtransform 关闭,提供一个新的处理跨平台样式注释判断的插件
postcss: {
     pxtransform: {
        enable: false,
        config: {}
     },
     crossPlatformComments: { // 暂时取名
         enable: true
     }
}
  1. pxtransform 职责分离
    i. 兼容:pxtransform 提供参数控制,关闭缩放,只生效 comments
    ii. 剥离干净:pxtransform 其实也提供一个新插件处理 comments,删除 pxtransform 有关的 comments 处理代码的逻辑,但是有历史包袱

总结:

第一种方案可以不动框架,比较便捷,第二种需要框架配合改动

@taro-bot2 taro-bot2 bot added the enhancement New feature or request label Feb 17, 2022
@shinken008 shinken008 changed the title pxtransform 多端开发样式不进行缩放也能支持跨平台注释代码 pxtransform enale false 样式不进行缩放也能支持跨平台注释代码 Feb 17, 2022
@shinken008 shinken008 changed the title pxtransform enale false 样式不进行缩放也能支持跨平台注释代码 pxtransform enable false 样式不进行缩放也能支持跨平台注释代码 Feb 17, 2022
@shinken008
Copy link
Collaborator Author

@zhiqingchen
Copy link
Member

需要框架配合的改动是?

@shinken008
Copy link
Collaborator Author

第一种方案,不需要改动框架

@shinken008
Copy link
Collaborator Author

方案二类似于拆分出一个文件,暂时是用第一种方案做的

@shinken008
Copy link
Collaborator Author

第一种方案,不需要改动框架

https://github.com/shinken008/postcss-crossplatformcomments

@zhiqingchen zhiqingchen added V-3 Version - 3.x T-rn Target - 编译到 React Native labels Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request T-rn Target - 编译到 React Native V-3 Version - 3.x
Projects
None yet
Development

No branches or pull requests

2 participants