Skip to content
This repository has been archived by the owner on Dec 11, 2022. It is now read-only.

invalid object? #68

Closed
jtoy opened this issue Feb 25, 2018 · 11 comments
Closed

invalid object? #68

jtoy opened this issue Feb 25, 2018 · 11 comments

Comments

@jtoy
Copy link
Contributor

jtoy commented Feb 25, 2018

I just tested running coach from source: 4fe9cba

on both ubuntu 14.04 and Macos high Sierra and I get the exact same error:

python coach.py -p CartPole_DQN -r

/home/jtoy/anaconda3/lib/python3.6/importlib/_bootstrap.py:205: RuntimeWarning: compiletime version 3.5 of module 'tensorflow.python.framework.fast_tensor_util' does not match runtime version 3.6
  return f(*args, **kwds)
Warning: failed to import the following packages - RoboSchool, GymExtensions, ViZDoom, CARLA, Neon
Please enter an experiment name: test
Using tensorflow framework
Traceback (most recent call last):
  File "coach.py", line 275, in <module>
    env_instance = create_environment(tuning_parameters)
  File "/home/jtoy/sandbox/touchnet/related_projects/coach/environments/__init__.py", line 32, in create_environment
    env = eval(env_type)(tuning_parameters)
  File "/home/jtoy/anaconda3/lib/python3.6/site-packages/pandas/core/computation/eval.py", line 267, in eval
    ret = eng_inst.evaluate()
  File "/home/jtoy/anaconda3/lib/python3.6/site-packages/pandas/core/computation/engines.py", line 75, in evaluate
    res = self._evaluate()
  File "/home/jtoy/anaconda3/lib/python3.6/site-packages/pandas/core/computation/engines.py", line 122, in _evaluate
    return ne.evaluate(s, local_dict=scope, truediv=truediv)
  File "/home/jtoy/anaconda3/lib/python3.6/site-packages/numexpr/necompiler.py", line 807, in evaluate
    zip(names, arguments)]
  File "/home/jtoy/anaconda3/lib/python3.6/site-packages/numexpr/necompiler.py", line 806, in <listcomp>
    signature = [(name, getType(arg)) for (name, arg) in
  File "/home/jtoy/anaconda3/lib/python3.6/site-packages/numexpr/necompiler.py", line 704, in getType
    raise ValueError("unknown type %s" % a.dtype.name)
ValueError: unknown type object

I installed all dependencies with pip install -r requirements_coach.txt

Is there an issue in master or am I missing something basic?

@jtoy
Copy link
Contributor Author

jtoy commented Feb 27, 2018

its because coach doesn't work on ubuntu 14.04 or mac, only 16.04. Would it be helpful if I added a docker image?

@zach-nervana
Copy link
Contributor

zach-nervana commented Feb 27, 2018

we internally have docker images, but cannot add them to this repository for licensing reasons that we are attempting to working out. Hopefully we can include one soon, thank you.

@jtoy
Copy link
Contributor Author

jtoy commented Feb 27, 2018

I just wrote a Dockerfile that works with CPU tensorflow, can I send a PR for this?

@zach-nervana
Copy link
Contributor

Unfortunately I don't think we can merge it yet if you do, @galnov what is the status of including Dockerfiles in this repository?

@jtoy
Copy link
Contributor Author

jtoy commented Mar 3, 2018

Here is my Dockerfile incase you all want it: https://gist.github.com/jtoy/2fee28d8931de0ce6b5883e4b5658560

@gal-leibovich
Copy link
Contributor

Thanks @jtoy!
As @zach-nervana mentioned, at the moment we cannot merge the Dockerfile in.
Closing the issue.

@r-lipton
Copy link

r-lipton commented Mar 9, 2018

I have the exact same problem running the example on a RHEL7.
Why it is only compatible with Ubuntu 16.04 ? The only solution is to use a docker container ?

@r-lipton
Copy link

r-lipton commented Mar 9, 2018

Seems like it's the eval function from pandas that does not work.
Using the python built-in eval did the job

@jtoy
Copy link
Contributor Author

jtoy commented Apr 14, 2018

I think this ticket should be reopened as the original issue is not addressed and it is an issue people will run into. Or alternatively open a new ticket for linux/Mac compatibility. If this error is fixed, this makes coach compatible with many more flavors of linux and Mac. I will investigate this issue more.

@jtoy
Copy link
Contributor Author

jtoy commented Apr 14, 2018

fixed it and now have coach working on Mac and ubuntu 14.04! I'll submit a PR.

@jtoy
Copy link
Contributor Author

jtoy commented Apr 14, 2018

here is the fix: #91

gal-leibovich pushed a commit that referenced this issue Nov 13, 2018
* refactoring the merging of the task parameters and the command line parameters
* removing some unused command line arguments
* fix for saving checkpoints when not passing through coach.py
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants