Logger logs done loading mention files before it actually does

[aribornstein]

Target objective:

Steps to objective:

nlp_architect/models/cross_doc_coref/system/cdc_utils.py

def load_mentions_vocab(mentions_files, filter_stop_words=False):
    logger.info('Loading mentions files...')
    mentions = []
    logger.info('Done loading mentions files, starting local dump creation...')
    for _file in mentions_files:
        mentions.extend(MentionData.read_mentions_json_to_mentions_data_list(_file))

    return extract_vocab(mentions, filter_stop_words)

Pull-Request related:

[AlonEirew]

great catch! thanks for sharing it, issue will be fixed soon

[github-actions]

Issue marked as stale, closing.