Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for how many times hold action is repeated per second #60

Closed
Simsala91 opened this issue Feb 12, 2024 · 5 comments
Closed

Add option for how many times hold action is repeated per second #60

Simsala91 opened this issue Feb 12, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@Simsala91
Copy link

Simsala91 commented Feb 12, 2024

Currently, when you hold a button or the touchpad, it will repeat the action 10x per second. Personally, I think this is too much. But this mostly comes down to personal preference.

Describe the solution you'd like
Add an option that changes how often a button is repeated per second.
This could be an optional config for the card, for example:

type: custom:android-tv-card
remote_id: remote.google_chromecast
slider_id: media_player.google_chromecast
keyboard_id: media_player.google_chromecast_adb
hold_actions_per_second: 5   #default 10
...

@Simsala91 Simsala91 added the enhancement New feature or request label Feb 12, 2024
@Nerwyn
Copy link
Owner

Nerwyn commented Feb 12, 2024

Good idea, but it would make more sense to let users redefine the delay rather than the frequency. So something like repeat_delay with a default value of 100 (ms). I should also try to make this configurable for either all repeats or at a custom action level.

@Nerwyn
Copy link
Owner

Nerwyn commented Feb 17, 2024

Implemented in 3.4.0, which is still in alpha as I implement other feature requests. repeat_delay can be set in either the root of the config or in custom actions as follows:

repeat_delay: 500
custom_actions:
  volume_up:
    hold_action:
      action: repeat
      repeat_delay: 10
  volume_down:
    hold_action:
      action: repeat
      repeat_delay: 10

@Nerwyn Nerwyn self-assigned this Feb 17, 2024
@Nerwyn
Copy link
Owner

Nerwyn commented Feb 17, 2024

Ready to for testing and feedback in 3.4.0-beta.001!

@Simsala91
Copy link
Author

Tested both global setting and global setting + individual setting for action and looks very good , everything responding as expected 👍 Thank you! :)

@Nerwyn
Copy link
Owner

Nerwyn commented Feb 26, 2024

Added in 3.4.0

@Nerwyn Nerwyn closed this as completed Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants