Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text not readable / Text or Background Color adjustment #16

Closed
2 tasks done
whyisthisbroken opened this issue May 5, 2024 · 5 comments
Closed
2 tasks done

Text not readable / Text or Background Color adjustment #16

whyisthisbroken opened this issue May 5, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@whyisthisbroken
Copy link

whyisthisbroken commented May 5, 2024

Checklist:

  • I updated to the latest version available
  • I cleared the cache of my browser

Browser and Operating System:
Chrome latest

Description of problem:
Color / Text not readable. The Dark Blue is "Condition not passed"
Condition passed on Green is readable

Test Not passed
Test passed

@whyisthisbroken whyisthisbroken added the bug Something isn't working label May 5, 2024
@Nerwyn
Copy link
Owner

Nerwyn commented May 5, 2024

It looks like this is because text-primary-color uses the same value as accent-color. I'll have to see where else text-primary-color is used to make sure changing it won't make something else look bad.

image

@Nerwyn
Copy link
Owner

Nerwyn commented May 6, 2024

Fixed in 1.6.1.

@Nerwyn Nerwyn closed this as completed May 6, 2024
@Nerwyn
Copy link
Owner

Nerwyn commented May 7, 2024

@whyisthisbroken I think I'm going to have to revert this. It breaks the display of the add card button and calendar.
image

image

@Nerwyn Nerwyn reopened this May 7, 2024
@Nerwyn
Copy link
Owner

Nerwyn commented May 7, 2024

Found a better solution - use lovelace-background for text-primary-color).
image
image
image
Seems to also work in light mode, although for some reason the CSS of the add card button is different.

@Nerwyn
Copy link
Owner

Nerwyn commented May 7, 2024

Released 1.6.2.

@Nerwyn Nerwyn closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants