GetEvents GetEventsParams.Type array parameter is not handled by GetQueryParams function

[gagf01]

Describe the bug
When the GetEventsParams.Type parameter is passed to the GetEvents function, it generate an error because the GetQueryParams function can't handle arrays. It should transform them first to a comma separated list string before the json.Mashal call.

To Reproduce

GetEvents(
  ctx,
  c.Token.AccessToken,
  c.Realm,
  gocloak.GetEventsParams{
	  UserID: "some-user-id",
	  Type:   []string{"LOGIN"},
  })

// GetEvents : could not get events: json: cannot unmarshal array into Go value of type string

[michael87]

+1
I have the same issue when i do this:

GetEvents( ctx, c.Token.AccessToken, c.Realm, gocloak.GetEventsParams{ UserID: "some-user-id", First: 10, })

of course in the int32 format.

[StinkyPeach]

+2
I have the same issue when i do this:

client.GetEvents(context.Background(), jwt.AccessToken, KeycloakRealm, gocloak.GetEventsParams{
		UserID: gocloak.StringP("user_id"),
		Type: []string{"LOGIN"},

type GetEventsParams struct {
	Client    *string  `json:"client,omitempty"`
	DateFrom  *string  `json:"dateFrom,omitempty"`
	DateTo    *string  `json:"dateTo,omitempty"`
	First     *int32   `json:"first,string,omitempty"`
	IPAddress *string  `json:"ipAddress,omitempty"`
	Max       *int32   `json:"max,string,omitempty"`
	Type      []string `json:"type,omitempty"`
	UserID    *string  `json:"user,omitempty"`
}

func GetQueryParams(s interface{}) (map[string]string, error) {
	// if obj, ok := s.(GetGroupsParams); ok {
	// 	obj.OnMarshal()
	// 	s = obj
	// }
	b, err := json.Marshal(s)
	if err != nil {
		return nil, err
	}
	var res map[string]string
	err = json.Unmarshal(b, &res)
	if err != nil {
		return nil, err
	}
	return res, nil
}

The GetQueryParams function returns a map[string]string, but the type field of the GetEventsParams structure is []string.

[pla2aroi]

solution solved

create a new function GetEvents

res, err := GetEvents(ctx, gocloak.GetEventsParams{First: 10}, []string{"LOGIN", "LOGIN_ERROR"})

...

func GetEvents(ctx context.Context, params gocloak.GetEventsParams, paramTypes []string) (res []*gocloak.EventRepresentation, err error) {
	
        ...

	if len(paramTypes) > 0 {
		client.RestyClient().OnBeforeRequest(func(c *resty.Client, r *resty.Request) error {
			r.SetQueryParamsFromValues(url.Values{
				"type": paramTypes,
			})
			return nil
		})
	}

	return client.GetEvents(ctx, token, "realm-name", params)
}

[valerii15298]

@Nerzal any info if this will be addressed?