Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest Sensor name is missing #1354

Closed
rahulguptajss opened this issue Oct 19, 2022 · 3 comments · Fixed by #1440 or #1492
Closed

Rest Sensor name is missing #1354

rahulguptajss opened this issue Oct 19, 2022 · 3 comments · Fixed by #1440 or #1492

Comments

@rahulguptajss
Copy link
Contributor

From one of customer logs, There seems to be an issue with Rest sensor plugin. We don't expect sensor name to be missing.

{"level":"warn","Poller":"SCES1P000","plugin":"Rest:Sensor","object":"Sensor","key":"SNES1P012.","caller":"sensor/sensor.go:102","time":"2022-10-19T10:37:11+02:00","message":"missing instance key"} {"level":"warn","Poller":"SCES1P000","plugin":"Rest:Sensor","object":"Sensor","key":"SNES1P007.","caller":"sensor/sensor.go:102","time":"2022-10-19T10:37:11+02:00","message":"missing instance key"} {"level":"warn","Poller":"SCES1P000","plugin":"Rest:Sensor","object":"Sensor","key":"SNES1P008.","caller":"sensor/sensor.go:102","time":"2022-10-19T10:37:11+02:00","message":"missing instance key"} {"level":"warn","Poller":"SCES1P000","plugin":"Rest:Sensor","object":"Sensor","key":"SNES1P009.","caller":"sensor/sensor.go:102","time":"2022-10-19T10:37:11+02:00","message":"missing instance key"} {"level":"warn","Poller":"SCES1P000","plugin":"Rest:Sensor","object":"Sensor","key":"SNES1P011.","caller":"sensor/sensor.go:102","time":"2022-10-19T10:37:11+02:00","message":"missing instance key"} {"level":"warn","Poller":"SCES1P000","plugin":"Rest:Sensor","object":"Sensor","key":"SNES1P010.","caller":"sensor/sensor.go:102","time":"2022-10-19T10:37:11+02:00","message":"missing instance key"}

@rahulguptajss
Copy link
Contributor Author

Not reproducible internally. We have added enough logs and changed key which should be unique. Marking as done.

@cgrinds
Copy link
Collaborator

cgrinds commented Nov 16, 2022

aff-251 has lots of

{"level":"warn","Poller":"aff-251","collector":"Rest:Sensor","instKey":"53","caller":"rest/rest.go:452","time":"2022-11-16T04:31:00-05:00","message":"This instance is already processed. instKey is not unique"}
{"level":"warn","Poller":"aff-251","collector":"Rest:Sensor","instKey":"54","caller":"rest/rest.go:452","time":"2022-11-16T04:31:00-05:00","message":"This instance is already processed. instKey is not unique"}
{"level":"warn","Poller":"aff-251","collector":"Rest:Sensor","instKey":"55","caller":"rest/rest.go:452","time":"2022-11-16T04:31:00-05:00","message":"This instance is already processed. instKey is not unique"}
{"level":"warn","Poller":"aff-251","collector":"Rest:Sensor","instKey":"56","caller":"rest/rest.go:452","time":"2022-11-16T04:31:00-05:00","message":"This instance is already processed. instKey is not unique"}
{"level":"warn","Poller":"aff-251","collector":"Rest:Sensor","instKey":"57","caller":"rest/rest.go:452","time":"2022-11-16T04:31:00-05:00","message":"This instance is already processed. instKey is not unique"}
{"level":"warn","Poller":"aff-251","collector":"Rest:Sensor","instKey":"58","caller":"rest/rest.go:452","time":"2022-11-16T04:31:00-05:00","message":"This instance is already processed. instKey is not unique"}
{"level":"warn","Poller":"aff-251","collector":"Rest:Sensor","instKey":"59","caller":"rest/rest.go:452","time":"2022-11-16T04:31:00-05:00","message":"This instance is already processed. instKey is not unique"}
{"level":"warn","Poller":"aff-251","collector":"Rest:Sensor","instKey":"60","caller":"rest/rest.go:452","time":"2022-11-16T04:31:00-05:00","message":"This instance is already processed. instKey is not unique"}
{"level":"warn","Poller":"aff-251","collector":"Rest:Sensor","instKey":"61","caller":"rest/rest.go:452","time":"2022-11-16T04:31:00-05:00","message":"This instance is already processed. instKey is not unique"}
{"level":"warn","Poller":"aff-251","collector":"Rest:Sensor","instKey":"62","caller":"rest/rest.go:452","time":"2022-11-16T04:31:00-05:00","message":"This instance is already processed. instKey is not unique"}
{"level":"warn","Poller":"aff-251","collector":"Rest:Sensor","instKey":"63","caller":"rest/rest.go:452","time":"2022-11-16T04:31:00-05:00","message":"This instance is already processed. instKey is not unique"}
{"level":"warn","Poller":"aff-251","collector":"Rest:Sensor","instKey":"64","caller":"rest/rest.go:452","time":"2022-11-16T04:31:00-05:00","message":"This instance is already processed. instKey is not unique"}

@cgrinds cgrinds reopened this Nov 16, 2022
@rahulguptajss rahulguptajss linked a pull request Nov 16, 2022 that will close this issue
@rahulguptajss rahulguptajss removed their assignment Nov 16, 2022
@cgrinds
Copy link
Collaborator

cgrinds commented Nov 16, 2022

Verified with 22.11 build commit 062085f
The earlier error "This instance is already processed. instKey is not unique" is now fixed

@cgrinds cgrinds self-assigned this Nov 16, 2022
@cgrinds cgrinds removed their assignment Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants