Nagios plugins breaking in Freebsd 13.1 Release

[djadk84]

I'm building pkgsrc in a FreeBSD server but the Nagios plugins keep failing.

cat ../../CVS/Tag 
Tpkgsrc-2023Q4
net/nagios-plugins

# uname -a
FreeBSD server1 13.2-RELEASE FreeBSD 13.2-RELEASE releng/13.2-n254617-525ecfdad597 GENERIC amd64

# cat /etc/os-release 
NAME=FreeBSD
VERSION="13.2-RELEASE"
VERSION_ID="13.2"
ID=freebsd
ANSI_COLOR="0;31"
PRETTY_NAME="FreeBSD 13.2-RELEASE"
CPE_NAME="cpe:/o:freebsd:freebsd:13.2"
HOME_URL="https://FreeBSD.org/"
BUG_REPORT_URL="https://bugs.FreeBSD.org/"

5 warnings generated.
mv -f .deps/check_http.Tpo .deps/check_http.Po
/bin/sh ../libtool  --tag=CC   --mode=link clang -DNP_VERSION='""' -O2 -I/usr/include -I/usr/pkg/include  -L/usr/lib -Wl,-R/usr/lib -L/usr/pkg/lib -Wl,-R/usr/pkg/lib -L. -o check_http check_http.o libnpcommon.a ../lib/libnagiosplug.a ../gl/libgnu.a -lssl -lcrypto libnpcommon.a ../lib/libnagiosplug.a ../gl/libgnu.a -lssl -lcrypto   -L/usr/pkg/lib -lintl -L/usr/pkg/lib -liconv -R/usr/pkg/lib -lpthread -ldl 
libtool: link: clang -DNP_VERSION=\"\" -O2 -I/usr/include -I/usr/pkg/include -Wl,-R/usr/lib -Wl,-R/usr/pkg/lib -o check_http check_http.o  -L/usr/lib -L/usr/pkg/lib -L. libnpcommon.a ../lib/libnagiosplug.a ../gl/libgnu.a -lssl -lcrypto /usr/pkg/lib/libintl.so /usr/pkg/lib/libiconv.so -lpthread -ldl -Wl,-rpath -Wl,/usr/pkg/lib -Wl,-rpath -Wl,/usr/pkg/lib
clang -DLOCALEDIR=\"/usr/pkg/share/nagios/locale\" -DHAVE_CONFIG_H -I. -I..  -I.. -I../lib -I../gl -I../intl -I/usr/include -I/usr/include -I/usr/pkg/include -D_THREAD_SAFE -DNP_VERSION='""' -O2 -I/usr/include -I/usr/pkg/include -MT check_load.o -MD -MP -MF .deps/check_load.Tpo -c -o check_load.o check_load.c
In file included from check_load.c:36:
In file included from ./runcmd.h:29:
In file included from ./utils.h:17:
In file included from ../lib/utils_base.h:5:
In file included from ../gl/sha1.h:37:
../gl/gl_openssl.h:79:10: warning: 'SHA1_Init' is deprecated [-Wdeprecated-declarations]
{ (void) OPENSSL_FN (_Init) ((_gl_CTX *) ctx); }
         ^
../gl/gl_openssl.h:74:28: note: expanded from macro 'OPENSSL_FN'
#define OPENSSL_FN(suffix) _GLCRYPTO_CONCAT (_GLCRYPTO_PREFIX, suffix)
                           ^
../gl/gl_openssl.h:34:42: note: expanded from macro '_GLCRYPTO_CONCAT'
#define _GLCRYPTO_CONCAT(prefix, suffix) _GLCRYPTO_CONCAT_ (prefix, suffix)
                                         ^
../gl/gl_openssl.h:33:43: note: expanded from macro '_GLCRYPTO_CONCAT_'
#define _GLCRYPTO_CONCAT_(prefix, suffix) prefix##suffix
                                          ^
<scratch space>:7:1: note: expanded from here
SHA1_Init
^
/usr/pkgsrc/net/nagios-plugins/work/.buildlink/include/openssl/sha.h:49:1: note: 'SHA1_Init' has been explicitly marked deprecated here
OSSL_DEPRECATEDIN_3_0 int SHA1_Init(SHA_CTX *c);
^
/usr/pkgsrc/net/nagios-plugins/work/.buildlink/include/openssl/macros.h:193:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
#   define OSSL_DEPRECATEDIN_3_0                OSSL_DEPRECATED(3.0)
                                                ^
/usr/pkgsrc/net/nagios-plugins/work/.buildlink/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
#     define OSSL_DEPRECATED(since) __attribute__((deprecated))
                                                   ^
In file included from check_load.c:36:
In file included from ./runcmd.h:29:
In file included from ./utils.h:17:
In file included from ../lib/utils_base.h:5:
In file included from ../gl/sha1.h:37:
../gl/gl_openssl.h:85:3: warning: 'SHA1_Update' is deprecated [-Wdeprecated-declarations]
{ OPENSSL_FN (_Update) ((_gl_CTX *) ctx, buf, len); }
  ^
../gl/gl_openssl.h:74:28: note: expanded from macro 'OPENSSL_FN'
#define OPENSSL_FN(suffix) _GLCRYPTO_CONCAT (_GLCRYPTO_PREFIX, suffix)
                           ^
../gl/gl_openssl.h:34:42: note: expanded from macro '_GLCRYPTO_CONCAT'
#define _GLCRYPTO_CONCAT(prefix, suffix) _GLCRYPTO_CONCAT_ (prefix, suffix)
                                         ^
../gl/gl_openssl.h:33:43: note: expanded from macro '_GLCRYPTO_CONCAT_'
#define _GLCRYPTO_CONCAT_(prefix, suffix) prefix##suffix
                                          ^
<scratch space>:16:1: note: expanded from here
SHA1_Update
^
/usr/pkgsrc/net/nagios-plugins/work/.buildlink/include/openssl/sha.h:50:1: note: 'SHA1_Update' has been explicitly marked deprecated here
OSSL_DEPRECATEDIN_3_0 int SHA1_Update(SHA_CTX *c, const void *data, size_t len);
^
/usr/pkgsrc/net/nagios-plugins/work/.buildlink/include/openssl/macros.h:193:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
#   define OSSL_DEPRECATEDIN_3_0                OSSL_DEPRECATED(3.0)
                                                ^
/usr/pkgsrc/net/nagios-plugins/work/.buildlink/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
#     define OSSL_DEPRECATED(since) __attribute__((deprecated))
                                                   ^
In file included from check_load.c:36:
In file included from ./runcmd.h:29:
In file included from ./utils.h:17:
In file included from ../lib/utils_base.h:5:
In file included from ../gl/sha1.h:37:
../gl/gl_openssl.h:94:3: warning: 'SHA1_Final' is deprecated [-Wdeprecated-declarations]
{ OPENSSL_FN (_Final) ((unsigned char *) res, (_gl_CTX *) ctx); return res; }
  ^
../gl/gl_openssl.h:74:28: note: expanded from macro 'OPENSSL_FN'
#define OPENSSL_FN(suffix) _GLCRYPTO_CONCAT (_GLCRYPTO_PREFIX, suffix)
                           ^
../gl/gl_openssl.h:34:42: note: expanded from macro '_GLCRYPTO_CONCAT'
#define _GLCRYPTO_CONCAT(prefix, suffix) _GLCRYPTO_CONCAT_ (prefix, suffix)
                                         ^
../gl/gl_openssl.h:33:43: note: expanded from macro '_GLCRYPTO_CONCAT_'
#define _GLCRYPTO_CONCAT_(prefix, suffix) prefix##suffix
                                          ^
<scratch space>:31:1: note: expanded from here
SHA1_Final
^
/usr/pkgsrc/net/nagios-plugins/work/.buildlink/include/openssl/sha.h:51:1: note: 'SHA1_Final' has been explicitly marked deprecated here
OSSL_DEPRECATEDIN_3_0 int SHA1_Final(unsigned char *md, SHA_CTX *c);
^
/usr/pkgsrc/net/nagios-plugins/work/.buildlink/include/openssl/macros.h:193:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
#   define OSSL_DEPRECATEDIN_3_0                OSSL_DEPRECATED(3.0)
                                                ^
/usr/pkgsrc/net/nagios-plugins/work/.buildlink/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
#     define OSSL_DEPRECATED(since) __attribute__((deprecated))
                                                   ^
In file included from check_load.c:36:
In file included from ./runcmd.h:29:
In file included from ./utils.h:17:
In file included from ../lib/utils_base.h:5:
In file included from ../gl/sha1.h:37:
../gl/gl_openssl.h:105:3: warning: 'SHA1_Final' is deprecated [-Wdeprecated-declarations]
  OPENSSL_FN (_Final) ((unsigned char *) res, &tmp_ctx);
  ^
../gl/gl_openssl.h:74:28: note: expanded from macro 'OPENSSL_FN'
#define OPENSSL_FN(suffix) _GLCRYPTO_CONCAT (_GLCRYPTO_PREFIX, suffix)
                           ^
../gl/gl_openssl.h:34:42: note: expanded from macro '_GLCRYPTO_CONCAT'
#define _GLCRYPTO_CONCAT(prefix, suffix) _GLCRYPTO_CONCAT_ (prefix, suffix)
                                         ^
../gl/gl_openssl.h:33:43: note: expanded from macro '_GLCRYPTO_CONCAT_'
#define _GLCRYPTO_CONCAT_(prefix, suffix) prefix##suffix
                                          ^
<scratch space>:48:1: note: expanded from here
SHA1_Final
^
/usr/pkgsrc/net/nagios-plugins/work/.buildlink/include/openssl/sha.h:51:1: note: 'SHA1_Final' has been explicitly marked deprecated here
OSSL_DEPRECATEDIN_3_0 int SHA1_Final(unsigned char *md, SHA_CTX *c);
^
/usr/pkgsrc/net/nagios-plugins/work/.buildlink/include/openssl/macros.h:193:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
#   define OSSL_DEPRECATEDIN_3_0                OSSL_DEPRECATED(3.0)
                                                ^
/usr/pkgsrc/net/nagios-plugins/work/.buildlink/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
#     define OSSL_DEPRECATED(since) __attribute__((deprecated))
                                                   ^
check_load.c:145:23: warning: relational comparison result unused [-Wunused-comparison]
        for (i = 0, j = 0; i < len, j < len; i++, j++) {
                           ~~^~~~~
check_load.c:362:44: error: use of undeclared identifier 'procjid'
        sscanf (* (char * const *) p1, PS_FORMAT, PS_VARLIST);
                                                  ^
../config.h:1999:58: note: expanded from macro 'PS_VARLIST'
#define PS_VARLIST procstat,&procuid,&procpid,&procppid,&procjid,&procvsz,&procrss,&procpcpu,procprog,&pos
                                                         ^
check_load.c:364:44: error: use of undeclared identifier 'procjid'
        sscanf (* (char * const *) p2, PS_FORMAT, PS_VARLIST);
                                                  ^
../config.h:1999:58: note: expanded from macro 'PS_VARLIST'
#define PS_VARLIST procstat,&procuid,&procpid,&procppid,&procjid,&procvsz,&procrss,&procpcpu,procprog,&pos
                                                  ^
5 warnings and 2 errors generated.
gmake[2]: *** [Makefile:2274: check_load.o] Error 1
gmake[2]: Leaving directory '/usr/pkgsrc/net/nagios-plugins/work/nagios-plugins-2.4.3/plugins'
gmake[1]: *** [Makefile:1587: all-recursive] Error 1
gmake[1]: Leaving directory '/usr/pkgsrc/net/nagios-plugins/work/nagios-plugins-2.4.3'
gmake: *** [Makefile:1511: all] Error 2
*** Error code 2
Stop.
bmake[1]: stopped in /usr/pkgsrc/net/nagios-plugins
*** Error code 1
Stop.
bmake: stopped in /usr/pkgsrc/net/nagios-plugins

[bsiegert]

This sounds like an OpenSSL incompatibility. Is this using builtin OpenSSL or from pkgsrc?

If this is using builtin, try setting

PREFER_PKGSRC=openssl

in your mk.conf.