Skip to content
This repository has been archived by the owner on May 17, 2022. It is now read-only.

xss.js should work with SlimerJS #11

Open
laurentj opened this issue Sep 17, 2014 · 2 comments
Open

xss.js should work with SlimerJS #11

laurentj opened this issue Sep 17, 2014 · 2 comments

Comments

@laurentj
Copy link

There are two scripts, xss.js and slimer.js and they are similar.

They should be identical since SlimerJS is theorically almost 100% compatible with PhantomJS. At least, what xss.js does should work with SlimerJS.

If something does not work with SlimerJS, please fill issues on project github.com/laurentj/slimerjs.

There is at least some few things to fix:

This deprecate way

wp = new WebPage();

should be replaced by

wp = require("webpage").create();

And also many variables are not declared with the var keyword (this may cause warnings in verbose mode).

@forced-request
Copy link
Contributor

Hi @laurentj,

Thanks for the feedback. Ideally we would just leverage a single script, but when we built the slimer functionality originally there were a few functions we were getting held up with.

I'll modify the slimer script to use the non-derecated version of the webpage creation, and properly define JS variables, then see where we're at.

@forced-request
Copy link
Contributor

It looks like once this issue is resolved, they will be compatible: laurentj/slimerjs#284

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants