Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions per track is missing #11

Closed
HarelM opened this issue Aug 4, 2018 · 2 comments
Closed

Extensions per track is missing #11

HarelM opened this issue Aug 4, 2018 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@HarelM
Copy link
Contributor

HarelM commented Aug 4, 2018

I couldn't find a way (judging from the code) to add extensions to track.
Did I miss something?

@HarelM
Copy link
Contributor Author

HarelM commented Aug 4, 2018

I did miss something, the following is needed in order to write extension per track:
settings.ExtensionWriter.ConvertRouteExtension
Although I think this is a copy-paste mistake? should it be ConvertTrackExtension in the following code:

writer.WriteExtensions(this.Extensions, settings.ExtensionWriter.ConvertRouteExtension);

Probably worth adding this to the documentation when writing it.

@airbreather
Copy link
Member

Yeah it was a copy-paste error on that line

@airbreather airbreather added this to the Alpha 0.1.1 milestone Aug 4, 2018
@airbreather airbreather added the bug Something isn't working label Aug 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants