FTBS on Fedora 32 w/ GCC 10

[knight-of-ni]

Netatalk fails to build with GCC 10, complaining multiple definition of invalid_dircache_entries. Relevant error text is below.

This can be resolved by adding extern to the function declaration in in directory.h. Trivial PR is incoming.

netatalk-3.1.12-11.fc32 fails to build with GCC 10 in Fedora 32: libtool: link: gcc -pthread -DAPPLCNAME -DSERVERTEXT=\"/var/lib/netatalk/msg/\" -D_PATH_AFPDPWFILE=\"/etc/netatalk/afppasswd\" -D_PATH_AFPDUAMPATH=\"/usr/lib64/netatalk//\" -D_PATH_CONFDIR=\"/etc/netatalk/\" -D_PATH_STATEDIR=\"/var/lib/netatalk/\" -I/usr/include/tracker-2.0 -I/usr/include/tracker-2.0/libtracker-sparql -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libmount -I/usr/include/blkid -pthread -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -DDBUS_COMPILATION "-D_U_=__attribute__((unused))" -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection -pthread -Wl,-z -Wl,relro -Wl,--as-needed -Wl,-z -Wl,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -o .libs/afpd afpd-afp_config.o afpd-afp_dsi.o afpd-afp_options.o afpd-afp_util.o afpd-afprun.o afpd-afs.o afpd-appl.o afpd-auth.o afpd-catsearch.o afpd-desktop.o afpd-dircache.o afpd-directory.o afpd-enumerate.o afpd-extattrs.o afpd-fce_api.o afpd-fce_util.o afpd-file.o afpd-filedir.o afpd-fork.o afpd-hash.o afpd-main.o afpd-mangle.o afpd-messages.o afpd-nfsquota.o afpd-ofork.o afpd-quota.o afpd-spotlight_marshalling.o afpd-status.o afpd-switch.o afpd-uam.o afpd-uid.o afpd-unix.o afpd-volume.o afpd-spotlight.o afpd-acls.o afpd-afpstats.o afpd-afpstats_obj.o -Wl,--as-needed -Wl,--as-needed afp_dtrace.o -Wl,--export-dynamic  -ldbus-1 -lgthread-2.0 -ldbus-glib-1 ../../libatalk/.libs/libatalk.so -L/usr/lib64/ -lldap -ltdb -lgcrypt -lgpg-error -ldl -lacl -lattr -lgssapi_krb5 -lkrb5 -lk5crypto -lcom_err -lmariadb ../../etc/spotlight/.libs/libspotlight.a -ltracker-sparql-2.0 -lgio-2.0 -lgobject-2.0 -lgmodule-2.0 -lglib-2.0 -lcrack -pthread [...] /usr/bin/ld: afpd-appl.o: in function `$d': /builddir/build/BUILD/netatalk-3.1.12/etc/afpd/directory.h:94: multiple definition of `invalid_dircache_entries'; afpd-afp_dsi.o:/builddir/build/BUILD/netatalk-3.1.12/etc/afpd/directory.h:94: first defined here
--

[slowfranklin]

Fixed in master.