Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.2] Bug and compile time fixes for openssl 1.1 #131

Closed

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Oct 11, 2021

  • Fix for atalkd bug "setifaddr: eth0 (1-65534): Invalid argument. try specifying a smaller net range. "
  • Fix for compile time errors when using libssl 1.1

Credits goes to the authors of the patches referenced in the commit messages

@slowfranklin
Copy link
Member

Thanks for contributing! It seems the patch is for Netatalk 2.2 which is EOL. Eg atalkd has been removed in newer releases. The second patch is already part of master in a similar form. Not sure about the third patch, but it doesn't apply.

@rdmark
Copy link
Member Author

rdmark commented Nov 21, 2021

@slowfranklin Thanks for following up on this PR. Yes, you are correct that the patches are for Netatalk 2.2 in particular. Is there any chance you could revisit the decision to EOL 2.2? There is an ever increasing userbase of classic Macs out there now, with the boom in retro computing and all, and the deprecation of AppleTalk/DDP in 3.x you effectively cut off support for anything prior to Mac OS 8 (although 7.5 and 7.6 have upgrade paths by installing OpenTransport).

For context, I'm a contributor to the RaSCSI project, a device that emulates various SCSI devices for vintages Macs and other computers that support SCSI. We've introduced close integration with Netatalk in the latest stable release, for running an AppleShare server in parallel with emulated SCSI network adapters and hard drives. We've been relying on local patches and unofficial forks of Netatalk to make this work, and I'd love to be able to pivot to official Netatalk releases instead. However, Netatalk 2.2 just doesn't compile anymore with modern Linux toolchains.

@slowfranklin
Copy link
Member

People find interesting ways to torture themselves. :) We can of course integrate patches if that helps.

@slowfranklin slowfranklin reopened this Nov 21, 2021
@slowfranklin
Copy link
Member

Pushed to 2.2 branch. Thanks for contributing!

@rdmark
Copy link
Member Author

rdmark commented Nov 21, 2021

@slowfranklin Thanks for taking a second look at this! I appreciate it.

@rdmark rdmark changed the title Bug and compile time fixes for openssl 1.1 [2.2] Bug and compile time fixes for openssl 1.1 Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants