Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some compile errors #176

Merged
merged 1 commit into from
Apr 16, 2022

Conversation

JensKSP
Copy link
Contributor

@JensKSP JensKSP commented Apr 14, 2022

This fixes some compile issues that happen if some obsolete features are being turned on

@rdmark
Copy link
Member

rdmark commented Apr 15, 2022

@JensKSP May I ask which compiler and architecture you're using to compiler? I've been working in the Netatalk 2.2 codebase for some time and not run into these particular errors, so was just curious what the difference with your environment might be.

@JensKSP
Copy link
Contributor Author

JensKSP commented Apr 15, 2022

I guess you found the Dockerfile already?
It's Alpine Linux on x86_64.
I am running Netatalk on my Synology NAS to share data with the classic Macs of my collection.

@rdmark
Copy link
Member

rdmark commented Apr 15, 2022

@JensKSP What version of gcc does Alpine Linux come with? gcc --version

@JensKSP
Copy link
Contributor Author

JensKSP commented Apr 15, 2022

It uses gcc (Alpine 10.3.1_git20211027) 10.3.1 20211027 but more importantly musl libc.

@slowfranklin slowfranklin merged commit 95677a3 into Netatalk:branch-netatalk-2-2 Apr 16, 2022
@JensKSP JensKSP deleted the 2-2-build-fixes branch April 16, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants