Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No quota support on macOS #492

Merged
merged 1 commit into from Sep 18, 2023
Merged

No quota support on macOS #492

merged 1 commit into from Sep 18, 2023

Conversation

dgsga
Copy link
Contributor

@dgsga dgsga commented Sep 18, 2023

This commit fixes a new compilation error on macOS 14 (Sonoma)

@dgsga
No quota support on macOS
8f73402 
This commit fixes a new compilation error on macOS 14 (Sonoma)
@dgsga dgsga requested a review from rdmark September 18, 2023 18:55
@dgsga dgsga self-assigned this Sep 18, 2023
rdmark
rdmark approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@rdmark rdmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we remove the Quota feature altogether? :)

@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@dgsga
Copy link
Contributor Author

dgsga commented Sep 18, 2023

Shall we remove the Quota feature altogether? :)

I think so as storage capacity is not an issue with current SSD's and HDD's. If you're in agreement I'll strip it out (I can port a commit from my fork)

@dgsga dgsga merged commit f89ea24 into main Sep 18, 2023
5 checks passed
@dgsga dgsga deleted the dgsga-fix-macos-noquotasupport branch September 18, 2023 19:01
@rdmark
Copy link
Member

rdmark commented Sep 18, 2023

Shall we remove the Quota feature altogether? :)

I think so as storage capacity is not an issue with current SSD's and HDD's. If you're in agreement I'll strip it out (I can port a commit from my fork)

Yes I think so. Please create a ticket first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdmark rdmark rdmark approved these changes

Assignees

@dgsga dgsga

Labels
None yet
Projects
No open projects
3.1.18
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dgsga @rdmark