Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images grid #24

Closed
cogniSyb opened this issue Aug 15, 2023 · 2 comments · Fixed by #68
Closed

Images grid #24

cogniSyb opened this issue Aug 15, 2023 · 2 comments · Fixed by #68
Assignees
Labels
MVP Must have for october PDP Redesign FE Redesign FE task
Milestone

Comments

@cogniSyb
Copy link
Collaborator

cogniSyb commented Aug 15, 2023

Called gallery in the design, and serving the same function as Volvo Trucks' images-grid.

Requirements

  • The section will start with a heading containing a marker
  • Images will be placed in the same masonry grid on all viewports
  • Images are either square or landscape
  • On mobile, the gap between images is 8px
  • On desktop, the gap between images is 16px
  • A caption text will be shown on desktop, in capitals shown on a graphite background
  • Automatically transform the text to all caps
  • Assumption: there is a long list of assets, we only show the first 4 assets in a grid, and the others when clicking on the image, show in a lightbox with a carousel (separate issue Images grid carousel #38 )
  • For the MVP, we will have the same caption on grid and lightbox view.

Technical hint

  • Proposal: Use the fig caption tag
  • Redo the document containing the assets, to allow multiple assets, but only display the first 4

This block will be expanded with #38

@shirin27 shirin27 added the MVP Must have for october label Aug 18, 2023
@Lakshmishri Lakshmishri self-assigned this Aug 29, 2023
@Andrei-Boiangiu
Copy link
Collaborator

NOTE:
some of the pixel values from the figma design vs the PR branch differ

for ex you will find
351px on the figma design vs 344.86px on the PR
335px on figma vs 326.859px on the PR

as discussed with @cogniSyb , the current values on the PR are correct as the images are now shown always in a square box, or a rectactle box with an aspect ration of 4/3 and that it was confirmed there would be some pixel rounding issues

@Andrei-Boiangiu
Copy link
Collaborator

confirmed as done with the above mention regarding pixel values

@WendyKruger WendyKruger added this to the MT PDP milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MVP Must have for october PDP Redesign FE Redesign FE task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants