Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finance and Purchase block - horizontal cards #59

Closed
1 task
Lakshmishri opened this issue Aug 29, 2023 · 2 comments
Closed
1 task

Finance and Purchase block - horizontal cards #59

Lakshmishri opened this issue Aug 29, 2023 · 2 comments
Assignees
@cogniSyb
Labels
PDP
Milestone
MT PDP

Comments

@Lakshmishri
Copy link
Collaborator

Lakshmishri commented Aug 29, 2023 •
edited by shirin27
Loading

  • Figma design
  • Use V2 columns block , in a new variation V2 Columns (condensed) for example
  • In mobile they will be displayed after each other
  • Handle the block to have 2 links

NOTE: To be done after #41

UX points to be clarified:

  • Interactive elements on the block are not defined in the Mack core design kit; we propose to go for the defined link style, with the arrow icon.
@Lakshmishri Lakshmishri added PDP MVP Must have for october labels Aug 29, 2023
@BeckyMedlin
Copy link
Collaborator

Per discussion with Joe and Zoe, please move forward with your proposal for now for the interactive elements.

@DanielaPedrochevd DanielaPedrochevd removed the MVP Must have for october label Oct 23, 2023
@cogniSyb cogniSyb changed the title Finance and Purchase block Finance and Purchase block - horizontal cards Oct 26, 2023
@cogniSyb cogniSyb mentioned this issue Oct 26, 2023
Merged
@Andrei-Boiangiu
Copy link
Collaborator

confirmed as done
as tested on https://59-horizontal-cards--vg-macktrucks-com-rd--netcentric.hlx.page/drafts/syb/cards

with the mention that some of the px values differ slightly from the figma designs as to fit on the page

@cogniSyb cogniSyb mentioned this issue Nov 14, 2023
Closed
@WendyKruger WendyKruger added this to the MT PDP milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cogniSyb cogniSyb

Labels
PDP
Projects
None yet
Milestone
MT PDP
Development

When branches are created from issues, their pull requests are automatically linked.

59-horizontal-cards Netcentric/vg-macktrucks-com-rd
7 participants
@Lakshmishri @TomaszDziezykNetcentric @Andrei-Boiangiu @cogniSyb @WendyKruger @BeckyMedlin @DanielaPedrochevd