Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: 优化项目类型描述，提升开发体验 #53

Merged
merged 147 commits into from
Dec 17, 2022
Merged

types: 优化项目类型描述，提升开发体验 #53

merged 147 commits into from
Dec 17, 2022

Conversation

kiner-tang
Copy link
Collaborator

@kiner-tang kiner-tang commented Oct 27, 2022 •
edited

这个 PR 做了什么? (简要描述所做更改)

任务列表：

  • actionsheet
  • animate
  • badge
  • base
  • button
  • carousel
  • checkbox
  • col
  • color
  • common
  • datePicker
  • icon
  • imagePreview
  • index
  • input
  • layout
  • list
  • loading
  • modal
  • navbar
  • noticeBar
  • picker
  • pickerGroup
  • radio
  • rate
  • row
  • search
  • stepper
  • switch
  • tabbar
  • tabs
  • tag
  • toast
  • upload

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) fix #{issue id}
  • 新功能(Feature) resolve #{issue id}
  • 代码重构(Refactor)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 类型描述更新(TypeScript definition update)
  • 其他，请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 未涉及平台修改
  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

@auto-assign auto-assign bot requested a review from onlychild October 27, 2022 08:40
@vercel
Copy link

vercel bot commented Oct 27, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ossa-demo ✅ Ready (Inspect) Visit Preview Dec 17, 2022 at 1:34AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
ossa-doc ⬜️ Ignored (Inspect) Dec 17, 2022 at 1:34AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2022 •
edited

🦋 Changeset detected

Latest commit: 3e5ece7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ossa/loki Minor
ossaui Minor
ossa-demo Minor
ossa-doc Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kiner-tang and others added 6 commits December 2, 2022 10:29
@kiner-tang
fix: 修改部分 stepper 组件错误 与完善类型描述 (NeteaseYanxuan#99)
3c060a2
@github-actions
Version Packages (NeteaseYanxuan#96)
14e4389 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@CaedmonW
chore: change check modify command (NeteaseYanxuan#103)
ca7417e
@CaedmonW
Feature upload callback (NeteaseYanxuan#105)
56c33bd 
* feat(uplaod): add onImageClick

* fix: import path

* docs: onFail type definition

* fix: cnpm package install failed

* refactor: update typescript version

* chore: lock @swc/core to 1.3.6
@github-actions
Version Packages (NeteaseYanxuan#106)
fc269ba 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kiner-tang
feat: 类型描述
48647db
@kiner-tang kiner-tang self-assigned this Dec 12, 2022
This was linked to issues Dec 12, 2022
OSSA现有组件优化计划 #42
Open
部分Typescript类型书写错误 #52
Closed
各组件type文件里属性没有注释，导致代码提示体验差，不能提示属性的含义 0️⃣ @kiner-tang #66
Closed
CaedmonW
CaedmonW approved these changes Dec 16, 2022
View reviewed changes
Copy link
Collaborator

@CaedmonW CaedmonW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍👍👍

@kiner-tang kiner-tang merged commit 070c745 into NeteaseYanxuan:release Dec 17, 2022
@github-actions github-actions bot mentioned this pull request Dec 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaedmonW CaedmonW CaedmonW approved these changes

@onlychild onlychild Awaiting requested review from onlychild

@jianzhouf jianzhouf Awaiting requested review from jianzhouf

Assignees

@kiner-tang kiner-tang

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@kiner-tang @CaedmonW @Zeng-J @jianzhouf @EchoHub