Sort Client (Read/Write ASG followed by Write only) for add API #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3259,7 +3260,21 @@ public <T> boolean add(String key, T value, Transcoder<T> tc, int timeToLive) th | |||
| @Override | |||
| public <T> EVCacheLatch add(String key, T value, Transcoder<T> tc, int timeToLive, Policy policy) throws EVCacheException { | |||
| EVCacheClient[] clients = _pool.getEVCacheClientForWrite(); | |||
| return this.add(key, value, tc, timeToLive, policy, clients, clients.length - _pool.getWriteOnlyEVCacheClients().length); | |||
| EVCacheClient[] writeOnlyClients = _pool.getWriteOnlyEVCacheClients(); | |||
| // In case of adds , we skip adds to the pool if value is already present in the 1st client | |||
There was a problem hiding this comment.
Any concerns with enabling the same behavior as SET calls? Fan out writes to all ASGs that can take writes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
For ADD api we skip adding keys to the cluster if the key is present in the first client. Now if a new cluster is warmed with fewer keys, the ADDS might not go through as it doesn't respect read/write mode and this might result in drop in hit rate.
Fix:
Sorting the client (read/write ASG first then followed by write-only ASG). So now the ADD API with check if the key is present in ASG which is actually serving the traffic rather than write-only ASG.
Please let me know if you have any questions. Please review and let me know your comments. Thanks!