-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HystrixDashboard - threadpool does not display right TPS #1697
Comments
JagmohanSharma
pushed a commit
to JagmohanSharma/Hystrix
that referenced
this issue
Oct 16, 2017
Code changes to fix TPS calculation issue with hystrix thread pool in dashboard.
This was referenced Oct 16, 2017
Please see #1251 |
This was referenced Mar 30, 2018
Dashboard module moved to https://github.com/Netflix-Skunkworks/hystrix-dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In order to fix issue with TPS in hystrix-dashboard, code changes were made previously in hystrixCommand.js #1251, but as these changes were not done in hystrixThreadPool.js which causing a different value for TPS in threadpool section of dashboard.
Above line of code was removed from below method in previous changes in hystrixCommand.js:
But same calculation is also being done in hystrixThreadPool.js as below:
I think previously removed line(avg calculation for
propertyValue_metricsRollingStatisticalWindowInMilliseconds
) is also not required in hystrixThreadPool.js which causing wrong value for TPS in threadPool section of dashboard. I have updated code with this change and started a pull request for review. Please let me know if changes are good to go to fix this issue.The text was updated successfully, but these errors were encountered: