Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard displays error percentages above 100% when command shares name with thread pool #792

Closed
genshapiro opened this issue May 14, 2015 · 8 comments

Comments

@genshapiro
Copy link

dashboard snapshot

Dashboard displays error rates well above 100%...can this be explained or is this a bug?
Thanks

@mattrjacobs
Copy link
Contributor

A lot of those numbers look incorrect. If it's possible, could you attempt to downgrade Hystrix to 1.4.6 (core/metrics-stream/dashboard) and see if the issue exists there. I made a recent change that swapped out our implementation of latency data. I haven't personally reproduced this issue, but if you are able to with 1.4.7 and not with 1.4.6, then that is very useful info for me.

@genshapiro
Copy link
Author

we are on 1.3.18. Unfortunatelly, we cannot nimbly move between versions in out environment.

Another question came up - is this simply faulty reporting or could it possibly affect circut breaker decision logic?
Thanks

@mattrjacobs
Copy link
Contributor

Thanks for the version info - that rules out a class of errors.

Are you able to share some of your raw metrics data that the dashboard is consuming?

@mattrjacobs
Copy link
Contributor

Also, is this data being processed by Turbine, or is it coming directly from a single metrics stream?

@genshapiro
Copy link
Author

Apologies for late response. Yes, we are using Turbine. Also, what we noticed was if Command name is identical to Thread Pool Key name this issue occurs. We do see good dashboard stats in cases where command name is different from that of pool key. Thats an observation.
We are trying to collect more data now.

Thanks

@mattrjacobs
Copy link
Contributor

@genshapiro See this comment for one possible solution: #703 (comment).

@genshapiro
Copy link
Author

FYI - what we found in our settings was Dashboard was getting confused when command name and thread pool name were the same. As soon as the one of them was renamed the issue resolved itself and Dashboard displayed reasonable stats.

@mattrjacobs
Copy link
Contributor

Thanks for the follow-up, @genshapiro. I'm changing the title of this Issue to reflect your findings.

@mattrjacobs mattrjacobs changed the title Dashboard displays error percentages above 100% Dashboard displays error percentages above 100% when command shares name with thread pool Jun 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants