Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServerSentEventEncoder is sub-optimal in using StringBuilder #261

Closed
NiteshKant opened this issue Oct 28, 2014 · 0 comments
Closed

ServerSentEventEncoder is sub-optimal in using StringBuilder #261

NiteshKant opened this issue Oct 28, 2014 · 0 comments
Assignees
@NiteshKant
Milestone
0.3.16

Comments

@NiteshKant
Copy link
Member

ServerSentEventEncoder uses a temporary StringBuilder to create a SSE string. Instead it can directly build netty's ByteBuf
@NiteshKant NiteshKant self-assigned this Oct 28, 2014
@NiteshKant NiteshKant added this to the 0.3.16 milestone Oct 28, 2014
@NiteshKant NiteshKant mentioned this issue Oct 29, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NiteshKant NiteshKant

Labels
None yet
Projects
None yet
Milestone
0.3.16
Development

No branches or pull requests
1 participant
@NiteshKant