Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URI fragment must be inherited by the redirect location #271

Closed
NiteshKant opened this issue Nov 4, 2014 · 1 comment
Closed

URI fragment must be inherited by the redirect location #271

NiteshKant opened this issue Nov 4, 2014 · 1 comment
Assignees
Milestone

Comments

@NiteshKant
Copy link
Member

For 3xx redirects, according to spec: http://tools.ietf.org/html/rfc7231#section-7.1.2 the redirect URI must carry forward the URI fragment from the original request if not provided in the redirect location.

@NiteshKant NiteshKant self-assigned this Nov 4, 2014
@NiteshKant NiteshKant added this to the 0.3.18 milestone Nov 4, 2014
NiteshKant pushed a commit to NiteshKant/RxNetty that referenced this issue Nov 5, 2014
ReactiveX#269(`ServerSentEventDecoder` stops decoding after receiving an illegal field): Now ignoring all data till an EOL after receiving an unidentified field, in essence ignoring that event.
ReactiveX#270: HttpClient should only do relative redirects
ReactiveX#271: URI fragment must be inherited by the redirect location
ReactiveX#272(Guaranteeing sequential notifications from operators/Subjects): Using `SerializedSubject` in `ObservableConnection.getInput()` and `SerializedObserver` in `UnicastContentSubject`
ReactiveX#257 Support relative HTTP redirects
@NiteshKant
Copy link
Member Author

Now, the redirect URI inherits the fragment if none present. The behavior follows as described in this example in the spec:

For example, a GET request generated for the URI reference
   "http://www.example.org/~tim" might result in a 303 (See Other)
   response containing the header field:

     Location: /People.html#tim

   which suggests that the user agent redirect to
   "http://www.example.org/People.html#tim"

   Likewise, a GET request generated for the URI reference
   "http://www.example.org/index.html#larry" might result in a 301
   (Moved Permanently) response containing the header field:

     Location: http://www.example.net/index.html

   which suggests that the user agent redirect to
   "http://www.example.net/index.html#larry", preserving the original
   fragment identifier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant