Abstraction of email transport and message generation. #115
Conversation
|
SimianArmy-pull-requests #116 FAILURE |
|
SimianArmy-pull-requests #117 FAILURE |
|
This looks like a Hudson CI failure rather than a failure caused by the commit. I get a successful build when I run "gradle clean build". Stack trace from Hudson console output suggests that the build never even started. Waiting to see if another build will kick off. |
Edited a comment to see if it would kick off a new build. Last build failed due to an error in the CI environment, and I don't see a retry happening.
|
SimianArmy-pull-requests #118 SUCCESS |
… into email-abstraction
|
SimianArmy-pull-requests #119 SUCCESS |
|
SimianArmy-pull-requests #120 SUCCESS |
|
SimianArmy-pull-requests #121 SUCCESS |
|
Is there still interest in merging this PR? It is the start of a large abstraction away from AWS that didn't get beyond the email notification stage in this PR. If there is interest I can merge, otherwise I am going to close it. |
|
Personally I got way beyond it, but when no interest was shown in merging my changes I just moved forward on my own fork. Let me know if you want to see the rest of it (or just find it on github). Some of the changes are in a private repo at work but I could make them public. Sent from my iPhone
|
|
Thanks for the reply. If you have moved on I am inclined to close this PR. Merging a year's worth of changes on a fork isn't the most appealing idea, especially if no one is interested in the result. But I am willing to put work into it if there is interest. |
This request contains one commit that was merged in from SimianArmy on Netflix:master (removal of java 1.6 requirement). Tests run (and new tests written), no regressions. Comments welcome!
The purpose of this PR is to start work on abstraction of "cloud" and "cluster" ideas (all still abstract) from some of the tightly coupled AWS dependencies that exist in those base classes. This particular branch allows a non-aws user to send notifications through a specified SMTP server. Our particular use case is that we are a cloud provider (rather than an app developer who deploys to a cloud provider). SimianArmy has the same intrinsic value for cloud providers (taking out machines to see if the cluster will survive without interrupting the user experience), but we obviously can't route mail through the AWS email service.