Option for non-SDB MonkeyRecorder

[huxoll]

This change uses a property to load a MonkeyRecorder, so an alternate can be used when SDB is not available/desired. This is critical for non-AWS cloud environments, where there may not be a natural equivalent for SDB.

[cloudbees-pull-request-builder]

SimianArmy-pull-requests #73 FAILURE
Looks like there's a problem with this pull request

[cloudbees-pull-request-builder]

SimianArmy-pull-requests #74 FAILURE
Looks like there's a problem with this pull request

[cloudbees-pull-request-builder]

SimianArmy-pull-requests #75 FAILURE
Looks like there's a problem with this pull request

[cloudbees-pull-request-builder]

SimianArmy-pull-requests #76 FAILURE
Looks like there's a problem with this pull request

[cloudbees-pull-request-builder]

SimianArmy-pull-requests #77 FAILURE
Looks like there's a problem with this pull request

[cloudbees-pull-request-builder]

SimianArmy-pull-requests #78 SUCCESS
This pull request looks good

[coryb]

Hi, thanks for the pull request, it is a good idea. Sorry for the delay.

I think the SimplerDBRecorder name is clever, but I would rather it be more obvious, something like LocalDBRecorder maybe? And I think the config settings prefix should be something like simianarmy.recorder.localdb.... and moved to the simianarmy.properties.

The simianarmy.client.recorder.class in the client.properties is good, but I would rather the default stay with SDB for now. I would leave a comment to switch to your implementation, but explicitly set the default value to com.netflix.simianarmy.aws.SimpleDBRecorder. The advantage of SDB over your SimplerDB is obviously that it has off-host storage, and if you are running chaos monkey in the cloud it will terminate itself periodically thereby losing all the events stored on local storage.

Thanks!
-Cory

[huxoll]

Hi,

That makes sense; I committed changes with those suggestions.

Cheers,
-John

On Tue, Sep 24, 2013 at 8:07 PM, coryb - notifications@github.com <
github.huxoll.17cf489050.notifications#github.com@ob.0sg.net> wrote:

Hi, thanks for the pull request, it is a good idea. Sorry for the delay.

I think the SimplerDBRecorder name is clever, but I would rather it be
more obvious, something like LocalDBRecorder maybe? And I think the config
settings prefix should be something like simianarmy.recorder.localdb....
and moved to the simianarmy.properties.

The simianarmy.client.recorder.class in the client.properties is good, but
I would rather the default stay with SDB for now. I would leave a comment
to switch to your implementation, but explicitly set the default value to
com.netflix.simianarmy.aws.SimpleDBRecorder. The advantage of SDB over your
SimplerDB is obviously that it has off-host storage, and if you are running
chaos monkey in the cloud it will terminate itself periodically thereby
losing all the events stored on local storage.

Thanks!
-Cory

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/95#issuecomment-25055474
.

[cloudbees-pull-request-builder]

SimianArmy-pull-requests #81 SUCCESS
This pull request looks good

[coryb]

Thanks for the pull request!
-Cory