Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asgard is unable to talk to a Eureka that has no urlContext #313

Open
cquinn opened this issue May 31, 2013 · 1 comment
Open

Asgard is unable to talk to a Eureka that has no urlContext #313

cquinn opened this issue May 31, 2013 · 1 comment

Comments

@cquinn
Copy link

cquinn commented May 31, 2013

We've setup our Eureka instance at the ROOT context in tomcat. So its url looks like hostname:8080/v2/... . There is no (redundant) 'eureka' in the url.

Setting Asgard's eureka.urlContext to '' in theory should work, but the code in Asgard treats null/blank as "use default" and uses '/eureka' instead.

There should be a way to indicate that a "no context" url us really desired.

@joesondow
Copy link
Contributor

Yup. I always wondered if this idea would come up. Carl, are you going to assign this to yourself and make the no-context option possible?

Hint: Add more logic in DiscoveryService.findBaseUrl (or EurekaService if it gets renamed), and also ConfigService.getEurekaUrlContext

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants