Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Update to graphql-java:20.1 #1467

Closed
AlexanderPraegla opened this issue Mar 28, 2023 · 6 comments
Closed

feature: Update to graphql-java:20.1 #1467

AlexanderPraegla opened this issue Mar 28, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@AlexanderPraegla
Copy link

Describe the Feature Request

Do you plan to update to graphql-java:20.1 in the near future? The current version 6.0.1 is unfortunately not compatible:

Caused by: java.lang.NoSuchMethodError: 'graphql.ExecutionResultImpl graphql.ExecutionResultImpl$Builder.build()'
	at com.netflix.graphql.dgs.DgsExecutionResult$Builder.<clinit>(DgsExecutionResult.kt:143)
@AlexanderPraegla AlexanderPraegla added the enhancement New feature or request label Mar 28, 2023
@AlexanderPraegla
Copy link
Author

This will fix the issue described in #1319 as they introduced "Record like property access support" with this PR on their side: graphql-java/graphql-java#2994

@spellew
Copy link
Collaborator

spellew commented Mar 30, 2023

Thanks for creating this issue. We'll start looking into updating graphql-java

@setchy
Copy link
Contributor

setchy commented Apr 3, 2023

Now 20.2 😄

@setchy
Copy link
Contributor

setchy commented Apr 3, 2023

In addition to updating the core graphql-java to 20.2, there are these related packages that should also be bumped to their 20.x equivalents

  • graphql-java-extended-scalars: 19.0 -> 20.2
  • graphql-java-extended-validation: 19.1 -> 20.0
  • federation-graphql-java-support: 2.1.0 -> 3.0.0

@srinivasankavitha
Copy link
Contributor

Thanks @setchy. We are in the process of trying the upgrade to understand the scope of breaking changes. This may take a bit longer since we would like to keep our internal framework versions inline with the OSS versions as well and it's purely for convenience to avoid maintenance overhead. This will involve a major version update, as well, so we need to evaluate the scope a bit more before releasing this. Will post an update shortly with a more concrete timeframe.

@AlexanderPraegla
Copy link
Author

Thank you for updating to graphql java 20.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants