Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an upload endpoint #104

Open
ghost opened this issue Feb 13, 2020 · 2 comments
Open

add an upload endpoint #104

ghost opened this issue Feb 13, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Feb 13, 2020

Thanks for this great project.
It would come handy having an upload endpoint, I forked the project and added one based on the base flask example but my react skills are close to none so I don't find it worth of a pull request, so, what about including one? I'm thinking on the scenario when we profile a remote host and want to upload the results directly to our application running in our workstation.

@mmarchini
Copy link
Contributor

An upload endpoint is probably a good idea. I would rather have it as upload -> process -> return flamegraph instead of saving the file to disk. Not sure what others think.

@ghost
Copy link
Author

ghost commented Feb 22, 2020

Would that mean adding the option to process whatever you send through that endpoint or changing the way the application works currently? I went for the upload and save locally because that meant upload, save and don't worry on keeping track on what's been uploaded because it is in the "examples" directory and that is already listed, so redirect to /# will have it listed when the page loads. It would be interesting to have both options, but probably that's more effort than people would want to invest in a part that is not core functionality (?).
Thank you @mmarchini for listening to my suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants