Option to discard bootstrap injector #102
Conversation
Using child injectors can be problematic in certain situations where the injector must be injected (usually part of framework code with dynamic class loading) resulting in the wrong injector being injected. While there are some workarounds to this problem they are not obvious and have issues of their own. This pull request make it possible to have the LifecycleInjector discard the bootstrap injector thereby making the injector returned by createInjector() a root injector.
| @@ -30,7 +30,6 @@ | |||
| private final List<Module> modules = Lists.newArrayList(); | |||
|
|
|||
| private static final String GUICE_PACKAGE_PREFX = "com.google.inject"; | |||
| private static final String GOVERNATOR_PACKAGE_PREFIX = "com.netflix.governator.guice"; | |||
|
|
|||
| public InternalModuleDependencyModule() { | |||
There was a problem hiding this comment.
low-case file name sneaked in again?
|
Please detail the problematic situations and why this is needed. |
…tor code into a new SimpleLifecycleInjector class
|
There are issues with JIT and the child injector in combination with Singletons. I'm specifically referring to things like https://groups.google.com/forum/#!topic/google-guice/2bznC6Al5DQ and https://groups.google.com/forum/#!topic/google-guice/Q592mWKTS1Q. While using child injectors to strictly enforce creation order is nice I don't think forcing child injectors on users of Governator is absolutely necessary. The proposed solution simply provides an alternative way of doing things. |
|
Is there a current problem/bug that you're trying to solve? The issues above have workarounds. This change significantly complicates Governator and imposes two implementations that have to be maintained. If there is a currently problem that needs to be solved let's solve that. If there isn't a current problem, I don't see the value of introducing a parallel implementation. |
|
Fixed by #103 |
Using child injectors can be problematic in certain situations where
the injector must be injected (usually part of framework code with
dynamic class loading) resulting in the wrong injector being injected.
While there are some workarounds to this problem they are not obvious
and have issues of their own. This pull request make it possible to
have the LifecycleInjector discard the bootstrap injector thereby
making the injector returned by createInjector() a root injector.