Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references from __assigned_ordinal objects #351

Open
DanielThomas opened this issue Nov 30, 2018 · 1 comment
Open

Remove references from __assigned_ordinal objects #351

DanielThomas opened this issue Nov 30, 2018 · 1 comment
Labels

Comments

@DanielThomas
Copy link
Member

Hollow's Memoized* collections and user implemented types that use the __assigned_ordinal optimization don't require their references once the object has been fed to the write state.

In my case, I implemented a Memoized interface that exposes a method I can call to drop references after the class is assigned an ordinal, but it occurred to me this is an optimization the producer could optionally take care of - perhaps collection specific clear/trim, nulling all reference fields of a user provided instance, etc.

@DanielThomas
Copy link
Member Author

Occurs to me that you'd have to be careful w/ concurrency when doing this optimization, so maybe it's just best left for advanced cases - perhaps a post-producer process that identifies opportunities for assigned ordinals or inlining?

@DanielThomas DanielThomas changed the title Remove referenced __assigned_ordinal objects Remove references from __assigned_ordinal objects Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant