Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

step-functions fails to deploy with resources decorator and integer values #1609

Closed
saikonen opened this issue Oct 24, 2023 · 0 comments · Fixed by #1610
Closed

step-functions fails to deploy with resources decorator and integer values #1609

saikonen opened this issue Oct 24, 2023 · 0 comments · Fixed by #1610

Comments

@saikonen
Copy link
Collaborator

Two examples that break with deploying to step-functions:

@resources
@batch(use_tmpfs=True)
@resources(shared_memory=1024)

The culprit is a combination of how compute_resource_attributes tries casting any numeric value to float, and outputting the max as a string, and step-functions relying on the batch implementation, which expects the correct types from the batch decorator for attributes (namely integers)

No issue exists with run --with batch due to the resources decorator attributes going through a json encode/decode before hitting the batch implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant