Skip to content
This repository has been archived by the owner on Sep 17, 2021. It is now read-only.

Hardcoded reference to Riot Games #1223

Open
blazingkin opened this issue Aug 22, 2019 · 4 comments
Open

Hardcoded reference to Riot Games #1223

blazingkin opened this issue Aug 22, 2019 · 4 comments

Comments

@blazingkin
Copy link

Seeing as this is a netflix product, the only hardcoding I would expect would be for Netflix.

Either way. This should probably be configurable

@mikegrima
Copy link
Contributor

That should be configurable. Please feel free to submit a PR to fix it.

@Niladri24dutta
Copy link

Niladri24dutta commented Sep 18, 2019

That should be configurable. Please feel free to submit a PR to fix it.

@mikegrima Can I create a PR for this? I think we can make it configurable by passing one extra argument like -o to mention the company name similarly what is being done for $website using positional parameter -w|--website . If the value is not set we can set it to some default value during the creation of ssl certificate. Let me know if my understanding is correct.

@Niladri24dutta
Copy link

Niladri24dutta commented Sep 18, 2019

@mikegrima here is the code which I am referring to

-w|--website) # Site (Domain) be used for the self-signed certificate

@sudo-ryan
Copy link
Contributor

#1232 👍🏻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants