Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fails on every release #1278

Open
nilfm opened this issue Dec 8, 2023 · 2 comments · Fixed by #1322
Open

CI fails on every release #1278

nilfm opened this issue Dec 8, 2023 · 2 comments · Fixed by #1322

Comments

@nilfm
Copy link
Contributor

nilfm commented Dec 8, 2023

https://github.com/Netflix/vmaf/actions/runs/7133167143/job/19425266007

The upload_url seems wrongly templated:

upload_url: [https://uploads.github.com/repos/Netflix/vmaf/releases/133078881/assets{?name,label}](https://uploads.github.com/repos/Netflix/vmaf/releases/133078881/assets%7B?name,label})

cc @kylophone if you know what is causing this, otherwise I'll investigate with low priority. Binaries are still being uploaded correctly, see here. Not sure if there's any impact at all.

@kylophone
Copy link
Collaborator

Oh, I think I know this one from awhile back. We have multiple jobs trying to upload a file with the same name, i.e. the MacOS / Linux vmaf binaries.

@nilfm
Copy link
Contributor Author

nilfm commented Dec 8, 2023

I see! From past releases I see we only release a single binary for Mac and Linux combined, and another one for Windows. I guess we could just add an if statement there so that it only uploads on a single job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants