Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other Motd/Advertisements #63

Open
Adrian8115 opened this issue Apr 27, 2024 · 1 comment
Open

Support other Motd/Advertisements #63

Adrian8115 opened this issue Apr 27, 2024 · 1 comment

Comments

@Adrian8115
Copy link

The currently supported motd is the motd used by mojang, but other games might use another motd structure.

This could easily be added with a simple enum like:

enum Advertisement {
   MinecraftBedrock(McMotd),
   Other(String),
}

This would also allow other advertisements to be supported, from other games/applications.

@john-bv
Copy link
Member

john-bv commented Apr 28, 2024

I like this idea, however I will more than likely isolate MCPE behind a feature flag like it is currently. I'm also not sure if I would do this with a enum, and i'd probably go more with a trait. I'll look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants