Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tests for consistent formatting for MU indications #786

Open
plural opened this issue Sep 1, 2023 · 1 comment
Open

Add Tests for consistent formatting for MU indications #786

plural opened this issue Sep 1, 2023 · 1 comment
Labels

Comments

@plural
Copy link
Collaborator

plural commented Sep 1, 2023

+N[mu] should always turn into +N mu in stripped_text and does not need a period after it.

Add a test to enforce this.

@infinitenutshell
Copy link

infinitenutshell commented Sep 2, 2023

Note that it's theoretically possible to have a +MU effect that does need a period, although I don't believe there is such an effect in the card pool currently. Namely, this would happen if the MU appears in a sentence instead of just being a standalone line e.g.

If [some condition], you get +1MU.

This may be a narrow enough futureproofing case that it's not worth working around until/unless it actually exists, but I'll let you make the call on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants