Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can spawn inside a ravine or a lava/water lake #89

Closed
NeunEinser opened this issue Nov 11, 2021 · 5 comments
Closed

You can spawn inside a ravine or a lava/water lake #89

NeunEinser opened this issue Nov 11, 2021 · 5 comments
Labels
bug Something isn't working Medium Prio
Milestone

Comments

@NeunEinser
Copy link
Owner

NeunEinser commented Nov 11, 2021

Currently, you can spawn inside a deep ravine or a lava/water lake

The reason for this is that the game currently only places a block of dirt if the block below the skybox at y=63 is water. If there is a water lake at a different level, or a ravine/lava lake, you can spawn inside of that.

I think it would be best to fix this by:

  1. Replace any type of air below spawn at y=63 and below with dirt
  2. Replace any type of liquid and cave air below spawn without y-level restriction with dirt
  3. The logic for placing the barrier block drop chute should stay the same.
@NeunEinser NeunEinser added bug Something isn't working Medium Prio labels Nov 11, 2021
@NeunEinser NeunEinser added this to the 5.0 Release milestone Nov 11, 2021
@NeunEinser NeunEinser changed the title You can spawn inside a ravind or lava You can spawn inside a ravine or lava Nov 11, 2021
@Kri5t0fK
Copy link
Contributor

Kri5t0fK commented Feb 13, 2022

With the ravine, it potentially makes more problems when you spawn on artificially placed block in the middle of ~11-wide ravine (with 5 blocks space on each side) you can't make it without having blocks in inv.

We would need to check for topmost blocks at a radius to determine spawnpoint/make a bigger platform then just 1 block.

@NeunEinser
Copy link
Owner Author

Yeah, I was thinking to simply make it a pillar instead of a single block, so you can break blocks below and get dirt that way to escape if not possible otherwise. IIRC 1.11 bingo also used a pillar for water spawns.

@Kri5t0fK
Copy link
Contributor

Yeah, I was thinking to simply make it a pillar (...)

Do it like that (pillar) or do we still want to think?

@NeunEinser
Copy link
Owner Author

Should be fixed in a way that prevents this from happening too
https://clips.twitch.tv/PerfectRespectfulGoblinPastaThat-Kj1DEhU9BB4bE1eN

@NeunEinser NeunEinser changed the title You can spawn inside a ravine or lava You can spawn inside a ravine or a lava/water lake Apr 2, 2022
@NeunEinser
Copy link
Owner Author

I updated the description at the top to state my plan of fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Medium Prio
Projects
None yet
Development

No branches or pull requests

2 participants