Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] #613 spike_train_generation module to handle multichannel AnalogSignal inputs #614

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

[Fix] #613 spike_train_generation module to handle multichannel AnalogSignal inputs #614

wants to merge 19 commits into from

Conversation

Moritz-Alexander-Kern
Copy link
Member

@Moritz-Alexander-Kern Moritz-Alexander-Kern commented Jan 19, 2024 •
edited

This PR closes #613.

This PR changes the handling of neo.AnalogSignals in elephant.spike_train_generation module.

  1. Type Annotations: Improved code readability with type annotations.

  2. Multichannel Support: handling of analog signals with multiple channels in spike_extraction, threshold_detection, and peak_detection.

  3. New Parameter: always_as_list: Ensures a consistent list output of SpikeTrains, even with single-channel input.

  4. Unit Tests: testing for various input types and values to validate reliability, and multichannel AnalogSignals

  5. Input Checks: Enhanced to catch errors related to incorrect input types.

todo:

  • return SpikeTrainList instead of List [SpikeTrain]
  • handle empty AnalogSignal

@coveralls
Copy link
Collaborator

coveralls commented Jan 19, 2024 •
edited

Coverage Status

coverage: 88.391% (+0.1%) from 88.264%
when pulling 51c9da3 on INM-6:fix/#613_spike_train_generation_peak_detection
into fe5053a on NeuralEnsemble:master.

@Moritz-Alexander-Kern Moritz-Alexander-Kern changed the title [Fix]#613 spike_train_generation module to handle multichannel AnalogSignal inputs [Fix] #613 spike_train_generation module to handle multichannel AnalogSignal inputs Jan 25, 2024
@Moritz-Alexander-Kern Moritz-Alexander-Kern added the enhancement Editing an existing module, improving something label Apr 4, 2024
@Moritz-Alexander-Kern Moritz-Alexander-Kern added this to the v1.2.0 milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdenker mdenker Awaiting requested review from mdenker

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement Editing an existing module, improving something
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

[Bug] peak_detection without analogsignals.times
2 participants
@Moritz-Alexander-Kern @coveralls