New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
poetry dependency management #150
Conversation
Another thing I've noticed - need to update Actions pipelines (switch them to poetry too). I'll do that a bit later |
Finished! We are completely ready to move to stable explicit crossplatform dependencies =) |
Thank you ! This PR is really nice. Regarding some specific dependencies :
This is a good idea to update the contributing page. |
Done |
@sylvchev I've added setup instructions to contribution file. (and also fixed the issues you pointed in change request) I guess this makes this PR mergeable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two typos to fix and we could merge!
Great! Then navigate straight to PyPI! |
I moved package management to
poetry
as I suggested in #146Separated development dependencies from direct ones. Run tests, evaluated
run.py
and built docs (here got some errors not related to dependencies).I've investigated
requirements.txt
and found funny things:pillow
andpatool
are not used anywhere, so I skipped adding them to poetry setuppyunpack
used only once and could be easily be replaced with standard library call (I'll open an issue later, or fix it directly with PR)m2r
is no longer supported, so I changed it tom2r2
which is a supported forknumpy
,scipy
andSphinx
are explicitly used but was not placed to explicit dependencies, fixed itLast but not least, I'll describe
poetry
(as well as development env) setup procedure inCONTRIBUTING
file in another PR. (this requires #151 to be merged to avoid conflicts)