Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neiry Demons P300 dataset #156

Merged
merged 17 commits into from Mar 30, 2021
Merged

Neiry Demons P300 dataset #156

merged 17 commits into from Mar 30, 2021

Conversation

v-goncharenko
Copy link
Collaborator

Added new dataset of visual P300 with multiclass labels

@sylvchev sylvchev self-requested a review March 19, 2021 12:55
@sylvchev sylvchev added enhancement dataset Supporting new dataset labels Mar 19, 2021
@v-goncharenko v-goncharenko marked this pull request as ready for review March 22, 2021 21:18
Copy link
Member

@sylvchev sylvchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks really great.

Could you confirm that there is 17 sessions per subject? In the MOABB context, we call runs consecutive recordings, that could include short breaks, where the subject keep the EEG on the head. A sessionrefers to recordings that are typically made during different days, or time of the day (morning/afternoon), where the user remove the EEG cap between session.

Also, could you add your dataset in the documentation file: docs/source/dataset.rst

@v-goncharenko
Copy link
Collaborator Author

@sylvchev it's done

moabb/datasets/neiry.py Show resolved Hide resolved
@sylvchev
Copy link
Member

Ok, merge!

@sylvchev sylvchev merged commit c652c77 into master Mar 30, 2021
@sylvchev sylvchev added this to the 0.4.0 milestone Mar 30, 2021
@v-goncharenko v-goncharenko deleted the neiry_demons branch March 31, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataset Supporting new dataset enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants