correct error in set_download_dir #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvchev
pushed a commit
that referenced
this pull request
Sep 3, 2021
* Avoid leaking information between sessions (#222) * clone pipelines in CV * PR should be made against develop branch * add WithinSubject update * add test for devel branch * Add coverage (#224) * add coverage * correct test * update coverage * investigate coverage issue * change coverage dir * change coverage file * correct error in set_download_dir (#225) * correct error in set_download_dir * add whats new * update readme with BCI definition (#228) * Ensure consistent channel order in paradigm (#229) * correct channel order, add ch_names to FakeDataset * correct ref to PR in whatsnew * prepare update to 0.4.3 (#230) * update download badge * add whats new in the doc menu * correct docstring * update to moabb 0.4.3 * correct doc generation (#232) * correct doc generation * build doc on push
jsosulski
pushed a commit
to jsosulski/moabb
that referenced
this pull request
Sep 23, 2021
* Avoid leaking information between sessions (NeuroTechX#222) * clone pipelines in CV * PR should be made against develop branch * add WithinSubject update * add test for devel branch * Add coverage (NeuroTechX#224) * add coverage * correct test * update coverage * investigate coverage issue * change coverage dir * change coverage file * correct error in set_download_dir (NeuroTechX#225) * correct error in set_download_dir * add whats new * update readme with BCI definition (NeuroTechX#228) * Ensure consistent channel order in paradigm (NeuroTechX#229) * correct channel order, add ch_names to FakeDataset * correct ref to PR in whatsnew * prepare update to 0.4.3 (NeuroTechX#230) * update download badge * add whats new in the doc menu * correct docstring * update to moabb 0.4.3 * correct doc generation (NeuroTechX#232) * correct doc generation * build doc on push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentionned in #197 the test to create the dir is not correct.