New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restricting Python < 3.11 version and adding tensorflow, keras, scikeras, braindecode, skorch and torch [optional] #329
Restricting Python < 3.11 version and adding tensorflow, keras, scikeras, braindecode, skorch and torch [optional] #329
Conversation
Hi @sylvchev, Can I merge? |
Thanks @bruAristimunha |
Hi @sylvchev, About the limitation of python, scikeras requires this restriction. I think it's silly, but without that, poetry won't let you add the library, even optionally. I defined the deep learning libraries as optional. |
I updated the command for the CI to install all dependencies |
When I regenerated the poetry.lock, we lost something you made to solve a problem with docs. Do you know how to fix this, @sylvchev?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in MOABB office hours, this is very nice.
thanks @bruAristimunha |
Hi guys, @carraraig and @sylvchev!
I am updating the python version 3.8 >= to be unsure that we can add the new dependencies (TensorFlow, Keras, Scikeras, braindecode and Pytorch). In this pull, I added Tensorflow, Keras and Scikeras. In PR #328, I added the braindecode and torch.
I'm still learning to work with Poetry, but I think everything is correct. @sylvchev, can you take a look and apply the merge if that's good for you?