Fixing circular import #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why I reduced the NumPy version?I changed the version NumPy because of the Google colab. I accidentally discovered a conflict! The version we are asking for in NumPy is different from the "native" version in colab in the GPU environment, we asked for 1.24, and they have 1.22 as default. However, when we try to upgrade, the TensorFlow and other libraries already installed conflict with NumPy and our poetry config. To solve reducing the NumPy version. It doesn't affect us at all. Since Google colab is a super popular tool, it's better not to put an error or a strange warning in the first line of code when the person tries to run moabb in the colab. In the CPU and TPU environment, there is no problem. Eventually, the colab will update, and we can update the NumPy version. |
sylvchev
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving the issue about circular import. Reported in the braindecode braindecode/braindecode#130