Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P300 annotations #396

Merged
merged 20 commits into from Jul 11, 2023
Merged

P300 annotations #396

merged 20 commits into from Jul 11, 2023

Conversation

Sara04
Copy link
Collaborator

@Sara04 Sara04 commented Jun 1, 2023

This PR fixes the problem with the annotation loading for the P300 datasets Sosulski2019, Huebner2017 and Huebner2018.

moabb/paradigms/p300.py Outdated Show resolved Hide resolved
@sylvchev sylvchev marked this pull request as ready for review July 4, 2023 01:16
@sylvchev
Copy link
Member

sylvchev commented Jul 4, 2023

You could use pre-commit to apply black formatting on your code and this is good to merge!

@Sara04
Copy link
Collaborator Author

Sara04 commented Jul 4, 2023

Thanks, @sylvchev !
There was still the problem with passing dict as a default argument since it is mutable data structure, so I've changed:
from
description_map = {"Stimulus/S 21": "Target", "Stimulus/S 1": "NonTarget"} (in class init arguments)
self.description_map = description_map
to
self.description_map = {"Stimulus/S 21": "Target", "Stimulus/S 1": "NonTarget"}

@bruAristimunha bruAristimunha merged commit 37f3618 into NeuroTechX:develop Jul 11, 2023
7 checks passed
@bruAristimunha
Copy link
Collaborator

Thank you @Sara04 and @sylvchev!

@Sara04 Sara04 deleted the P300_annotations branch July 12, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants