Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalise runs and sessions names #451

Closed
PierreGtch opened this issue Aug 4, 2023 · 0 comments · Fixed by #471
Closed

Normalise runs and sessions names #451

PierreGtch opened this issue Aug 4, 2023 · 0 comments · Fixed by #471
Milestone

Comments

@PierreGtch
Copy link
Collaborator

The naming scheme of the sessions and runs is not always consistent between datasets. They are usually prefixed by "session_" and "run_" but not always. They are usually followed by a number but not always (ex. Schirrmeister2017 has runs names "train" and "test"). If it's a number, it sometimes starts at 0 and sometimes at 1.
(The subjects names are always integers and, I think, always starting at 1)

The goal of this issue is to normalise all this to have run and session names that always reflect their chronology.
And while we are at it, we could directly make these names compatible with the BIDS specifications (i.e. only with letters and numbers. No spaces, dashes or underscores).

So we could use the following guidelines for (re)naming:

  • remove the prefixes session_ and run_ for compatibility with BIDS,
  • always begin the name with an integer that tells in which order the session/run was recorded (starting at 0 or 1?),
  • eventually add a string after the integer to provide additional information (ex: train/test) without separation in-between.

Also, we should add tests when loading the data and at least raise a warning if the names are incorrect.

@PierreGtch PierreGtch added this to the 0.6.0 milestone Aug 4, 2023
@PierreGtch PierreGtch modified the milestones: 0.6.0, 1.0.0 Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant