Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add c-VEP paradigm and first dataset #463

Merged
merged 38 commits into from Aug 23, 2023
Merged

Conversation

thijor
Copy link
Contributor

@thijor thijor commented Aug 18, 2023

Closes #366

@PierreGtch PierreGtch marked this pull request as draft August 18, 2023 08:05
moabb/paradigms/cvep.py Outdated Show resolved Hide resolved
moabb/datasets/thielen2021.py Outdated Show resolved Hide resolved
moabb/datasets/thielen2021.py Outdated Show resolved Hide resolved
moabb/datasets/thielen2021.py Outdated Show resolved Hide resolved
@PierreGtch
Copy link
Collaborator

PierreGtch commented Aug 18, 2023

  • update whats_new
  • add your name to list of contributors (bottom of whats_new)
  • update the list of datasets in the doc
  • update the list of paradigms in the doc
  • update the datasets_summary file in the doc
  • add tests for the cVEP paradigms in tests/paradigms.py
  • add cVEP case in tests/benchmark.py, in test_benchmark_strdataset() and test_benchmark_objdataset()
  • test also, with a fake dataset, the case when there are more than two stimulation levels

moabb/paradigms/cvep.py Outdated Show resolved Hide resolved
moabb/paradigms/cvep.py Outdated Show resolved Hide resolved
moabb/paradigms/cvep.py Outdated Show resolved Hide resolved
moabb/paradigms/cvep.py Outdated Show resolved Hide resolved
@PierreGtch PierreGtch marked this pull request as ready for review August 18, 2023 14:36
Copy link
Collaborator

@bruAristimunha bruAristimunha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thijor and @PierreGtch!

The code is very good! I was reviewing, and I posted my main comment in the review. It would be lovely to try to create some function in the thielen2021, especially in the part get_single_subject_data, to allow and to facilitate the integration of new CVEP datasets :)

moabb/datasets/thielen2021.py Show resolved Hide resolved
moabb/datasets/thielen2021.py Outdated Show resolved Hide resolved
moabb/datasets/thielen2021.py Outdated Show resolved Hide resolved
moabb/datasets/thielen2021.py Outdated Show resolved Hide resolved
moabb/datasets/thielen2021.py Outdated Show resolved Hide resolved
moabb/datasets/thielen2021.py Show resolved Hide resolved
moabb/datasets/thielen2021.py Outdated Show resolved Hide resolved
moabb/datasets/thielen2021.py Show resolved Hide resolved
docs/source/dataset_summary.rst Outdated Show resolved Hide resolved
moabb/tests/paradigms.py Outdated Show resolved Hide resolved
@bruAristimunha
Copy link
Collaborator

I will fix the pytest issue

Copy link
Collaborator

@bruAristimunha bruAristimunha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy :)

Copy link
Collaborator

@PierreGtch PierreGtch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too :D

@bruAristimunha
Copy link
Collaborator

Thank you @PierreGtch and @thijor =)

@bruAristimunha bruAristimunha merged commit 0505f61 into NeuroTechX:develop Aug 23, 2023
7 of 8 checks passed
@bruAristimunha
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

c-VEP datasets
3 participants