Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible results between version 0.6 and earlier #472

Closed
PierreGtch opened this issue Aug 28, 2023 · 3 comments · Fixed by #471
Closed

Incompatible results between version 0.6 and earlier #472

PierreGtch opened this issue Aug 28, 2023 · 3 comments · Fixed by #471
Milestone

Comments

@PierreGtch
Copy link
Collaborator

The results computed with MOABB version 5.0 and earlier will be incompatible with version 6.0 and later because we changed many dataset names and codes (#448 #455) and the sessions and runs naming scheme (#471 ).

How should we warn the users about that?

@PierreGtch PierreGtch added this to the 0.6.0 milestone Aug 28, 2023
@bruAristimunha
Copy link
Collaborator

It looks like an API break for me. It may be time to make the 1.0.0 version or find a way to load the results. What do you think @sylvchev?

@sylvchev
Copy link
Member

Not an API break for me, as this concern the results of computation and not the code. Nonetheless, I agree that we should move to 1.0.0 version! This is time and we should allow users that want to keep their previous results to stick with 0.x versions

Next question is, since we will move to a new major version that allow API breaks, do we have some API to break? It will a good opportunity, next one could be in a long time! I'm thinking about changes in names or parameter names of functions (to keep homogeneity with other libraries). Maybe a good time to see if we have a better take on evaluation.process and evaluation.evaluate for example.

@PierreGtch
Copy link
Collaborator Author

#460

@sylvchev sylvchev modified the milestones: 0.6.0, 1.0.0 Sep 8, 2023
@sylvchev sylvchev linked a pull request Sep 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants