Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case where no epochs in run #491

Merged
merged 13 commits into from Sep 25, 2023

Conversation

PierreGtch
Copy link
Collaborator

This fixes a case when the events are specified via the raw.annotations but no events are in it.

With this PR, if a run contains no valid epochs, it is just ignored. Should we add a parameter raise_if_empty_run as a safeguard? @sylvchev @bruAristimunha @carraraig

@PierreGtch PierreGtch marked this pull request as ready for review September 21, 2023 15:34
@bruAristimunha
Copy link
Collaborator

Can you please make more tests @PierreGtch?

@bruAristimunha bruAristimunha merged commit 1195ddb into NeuroTechX:develop Sep 25, 2023
9 checks passed
@bruAristimunha
Copy link
Collaborator

Thank @PierreGtch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants